Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OwnedRow #3079

Merged
merged 1 commit into from
Nov 10, 2022
Merged

feat: add OwnedRow #3079

merged 1 commit into from
Nov 10, 2022

Conversation

crepererum
Copy link
Contributor

Which issue does this PR close?

Closes #3078.

Rationale for this change

Providing a way to move/clone a row without referencing the whole buffer.

What changes are included in this PR?

New type OwnedRow.

Are there any user-facing changes?

No breaking change, just a new type.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 10, 2022
@crepererum
Copy link
Contributor Author

Windows CI fails w/

 failures:

---- column::reader::decoder::tests::test_skip stdout ----
thread 'column::reader::decoder::tests::test_skip' panicked at 'assertion failed: `(left == right)`
  left: `43`,
 right: `81`', parquet\src\column\reader\decoder.rs:506:21


failures:
    column::reader::decoder::tests::test_skip

test result: FAILED. 578 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 15.16s

error: test failed, to rerun pass `-p parquet --lib`

I'm pretty sure this is unrelated.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

I suggest we add some basic tests for them (if @tustvold agrees to the basic premise) that verify that the derived impls are consistent with the non owned version

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the derived impls simply delegate to Row I'm happy without tests

@tustvold tustvold merged commit 885a361 into apache:master Nov 10, 2022
@ursabot
Copy link

ursabot commented Nov 10, 2022

Benchmark runs are scheduled for baseline = 9f14683 and contender = 885a361. 885a361 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row Format: Option to detach/own a row
4 participants